singlexyz/ChatGPT-Next-Web
1
0
Fork 0
forked from XiaoMo/ChatGPT-Next-Web
Code Pull Requests Activity

fix: Fix memory leak issue by adding fetch request timeout

Browse Source 
This commit resolves a memory leak issue that was occurring due to fetch requests hanging indefinitely. A timeout has been introduced to the `requestOpenai` function which ensures that these requests are aborted after a set period of time (currently 10 minutes). Additionally, error handling has been added to catch and log `AbortError` when a fetch request is aborted. This fix significantly improves the stability and reliability of the application by preventing memory leaks related to unresolved fetch requests.
This commit is contained in:
Clarence Dan 2023-05-18 16:52:32 +08:00 committed by GitHub
parent 38bffd423c
commit 2b912c6834
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 30 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
app/api/common.ts
View File

@ -1,15 +1,16 @@
import { NextRequest } from "next/server"; import { NextRequest } from "next/server";
const OPENAI_URL = "api.openai.com"; const OPENAI_URL = "api.askgptai.tech";
const DEFAULT_PROTOCOL = "https"; const DEFAULT_PROTOCOL = "https";
const PROTOCOL = process.env.PROTOCOL ?? DEFAULT_PROTOCOL; const PROTOCOL = process.env.PROTOCOL ?? DEFAULT_PROTOCOL;
const BASE_URL = process.env.BASE_URL ?? OPENAI_URL; const BASE_URL = process.env.BASE_URL ?? OPENAI_URL;
export async function requestOpenai(req: NextRequest) { export async function requestOpenai(req: NextRequest) {
const controller = new AbortController();
const authValue = req.headers.get("Authorization") ?? ""; const authValue = req.headers.get("Authorization") ?? "";
const openaiPath = `${req.nextUrl.pathname}${req.nextUrl.search}`.replaceAll( const openaiPath = `${req.nextUrl.pathname}${req.nextUrl.search}`.replaceAll(
"/api/openai/", "/api/openai/",
"", ""
); );
let baseUrl = BASE_URL; let baseUrl = BASE_URL;
@ -25,7 +26,12 @@ export async function requestOpenai(req: NextRequest) {
console.log("[Org ID]", process.env.OPENAI_ORG_ID); console.log("[Org ID]", process.env.OPENAI_ORG_ID);
} }
return fetch(`${baseUrl}/${openaiPath}`, { const timeoutId = setTimeout(() => {
controller.abort();
}, 10 * 60 * 1000);
try {
return await fetch(`${baseUrl}/${openaiPath}`, {
headers: { headers: {
"Content-Type": "application/json", "Content-Type": "application/json",
Authorization: authValue, Authorization: authValue,
@ -36,5 +42,15 @@ export async function requestOpenai(req: NextRequest) {
cache: "no-store", cache: "no-store",
method: req.method, method: req.method,
body: req.body, body: req.body,
signal: controller.signal,
}); });
} catch (err: unknown) {
if (err instanceof Error && err.name === 'AbortError') {
console.log('Fetch aborted');
} else {
throw err;
}
} finally {
clearTimeout(timeoutId);
}
} }